fix: detector template (#1162)

* fix: detector template Signed-off-by: ericsyh <[email protected]> * update detector auth example Signed-off-by: ericsyh <[email protected]> * update template Signed-off-by: ericsyh <[email protected]> * update the template Signed-off-by: ericsyh <[email protected]> * update the template Signed-off-by: ericsyh <[email protected]> * fix the comment Signed-off-by: ericsyh <[email protected]> --------- Signed-off-by: ericsyh <[email protected]>
streamnative · May 20, 2024 · 45673ac · 45673ac
1 parent 93af2bb
commit 45673ac
Show file tree

Hide file tree

Showing 4 changed files with 28 additions and 10 deletions.
diff --git a/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml b/charts/sn-platform-slim/templates/detector/pulsar-detector-deployment.yaml
@@ -103,12 +103,16 @@ spec:
         {{- if .Values.pulsar_detector.extraArgs }}
         args:
         - >
-          bin/pulsar-detector \
+          bin/pulsar-detector
           {{- range $key, $value := .Values.pulsar_detector.extraArgs }}
-          -{{ $key }} {{ $value }} \
+          {{- if $value }}
+          -{{ $key }}={{ $value }} 
+          {{- else }}
+          -{{ $key }}
           {{- end }}
-          -service-url {{ template "pulsar.detector.serviceUrl" . }} \
-          -webservice-url {{ template "pulsar.detector.webServiceUrl" . }}};
+          {{- end }}
+          -service-url {{ template "pulsar.detector.serviceUrl" . }}
+          -webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
         {{- else }}
         args:
         - >

diff --git a/charts/sn-platform-slim/values.yaml b/charts/sn-platform-slim/values.yaml
@@ -1409,8 +1409,13 @@ pulsar_detector:
   ## Additional pulsar_detector container arguments
   extraArgs: {}
     # Configure the tls auth for detector
-    # auth-plugin: "tls"
+    # auth-plugin: tls
     # auth-params: "{\"tlsCertFile\":\"/pulsar/certs/pulsar-detector/tls.crt\",\"tlsKeyFile\":\"/pulsar/certs/pulsar-detector/tls.key\"}"
+    # Configure the tls auth for detector
+    # auth-plugin: token
+    # auth-params: "{\"token\":\"tokenVal\"}"
+    # Allow TLS insecure connection
+    # tls-allow-insecure: ""
   ## Proxy service
   ## templates/pulsar-detector-service.yaml
   ##

diff --git a/charts/sn-platform/templates/detector/pulsar-detector-deployment.yaml b/charts/sn-platform/templates/detector/pulsar-detector-deployment.yaml
@@ -103,12 +103,16 @@ spec:
         {{- if .Values.pulsar_detector.extraArgs }}
         args:
         - >
-          bin/pulsar-detector \
+          bin/pulsar-detector
           {{- range $key, $value := .Values.pulsar_detector.extraArgs }}
-          -{{ $key }} {{ $value }} \
+          {{- if $value }}
+          -{{ $key }}={{ $value }} 
+          {{- else }}
+          -{{ $key }}
           {{- end }}
-          -service-url {{ template "pulsar.detector.serviceUrl" . }} \
-          -webservice-url {{ template "pulsar.detector.webServiceUrl" . }}};
+          {{- end }}
+          -service-url {{ template "pulsar.detector.serviceUrl" . }}
+          -webservice-url {{ template "pulsar.detector.webServiceUrl" . }};
         {{- else }}
         args:
         - >

diff --git a/charts/sn-platform/values.yaml b/charts/sn-platform/values.yaml
@@ -1483,8 +1483,13 @@ pulsar_detector:
   ## Additional pulsar_detector container arguments
   extraArgs: {}
     # Configure the tls auth for detector
-    # auth-plugin: "tls"
+    # auth-plugin: tls
     # auth-params: "{\"tlsCertFile\":\"/pulsar/certs/pulsar-detector/tls.crt\",\"tlsKeyFile\":\"/pulsar/certs/pulsar-detector/tls.key\"}"
+    # Configure the tls auth for detector
+    # auth-plugin: token
+    # auth-params: "{\"token\":\"tokenVal\"}"
+    # Allow TLS insecure connection
+    # tls-allow-insecure: ""
   ## Proxy service
   ## templates/pulsar-detector-service.yaml
   ##