-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sn-platform][sn-platform-slim]: upgrade pulsar to 3.0 and enable 3.0 new features #1083
Merged
Merged
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0aabfbc
upgrade to use pulsar 3.0 on sn-platform
ericsyh 83b243f
upgrade pulsar to 3.0 on slim chart
ericsyh 60a17d9
update example
ericsyh f980a1f
disable direct io
ericsyh 1e5413a
remove transactionBufferSnapshotSegmentSize
ericsyh f33535c
don't enable the new LB by default
ericsyh 3c92573
fix lint
ericsyh 462b4a7
update to fix comments
ericsyh 1e7679e
Merge branch 'master' into upgrade-3.0
ericsyh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,22 +130,22 @@ monitoring: | |
images: | ||
zookeeper: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
customTools: | ||
backup: | ||
repository: "streamnative/pulsar-metadata-tool" | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
restore: | ||
repository: "streamnative/pulsar-metadata-tool" | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
bookie: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
presto: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
exporter: | ||
repository: bitnami/jmx-exporter | ||
|
@@ -154,36 +154,36 @@ images: | |
# NOTE: allow overriding the presto worker image | ||
# presto_worker: | ||
# repository: streamnative/sn-platform | ||
# tag: 2.10.4.7 | ||
# tag: 3.0.0.4 | ||
# pullPolicy: IfNotPresent | ||
autorecovery: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
broker: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
proxy: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
pulsar_detector: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
functions: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
function_worker: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
# NOTE: allow overriding the toolset image | ||
toolset: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
kafka: | ||
repository: confluentinc/cp-kafka | ||
|
@@ -239,7 +239,7 @@ images: | |
pullPolicy: IfNotPresent | ||
pulsar_metadata: | ||
repository: streamnative/sn-platform | ||
tag: "2.10.4.7" | ||
tag: "3.0.0.4" | ||
pullPolicy: IfNotPresent | ||
configmapReload: | ||
repository: jimmidyson/configmap-reload | ||
|
@@ -987,6 +987,8 @@ bookkeeper: | |
gcLoggingOptions: [] | ||
custom: {} | ||
configData: {} | ||
# For Pulsar 3.0, please do not enable Direct IO. Needs a fix https://github.com/apache/bookkeeper/pull/4041 | ||
# PULSAR_PREFIX_dbStorage_directIOEntryLogger: "true" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please change the default value to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @hangc0276 fixed in 462b4a7 |
||
## Operator Controller | ||
## templates/bookkeeper-cluster.yaml | ||
operator: | ||
|
@@ -1243,16 +1245,19 @@ broker: | |
extraOptions: [] | ||
gcLoggingOptions: [] | ||
configData: | ||
# @deprecated: | ||
# 1. You can use a service account to assume an IAM role to access S3 bucket | ||
# 2. You can use a k8s secret to reference AWS credentials. See `offload.s3.secret` | ||
# AWS_ACCESS_KEY_ID: "[YOUR AWS ACCESS KEY ID]" | ||
# AWS_SECRET_ACCESS_KEY: "[YOUR SECRET]" | ||
managedLedgerDefaultEnsembleSize: "3" | ||
managedLedgerDefaultWriteQuorum: "3" | ||
managedLedgerDefaultAckQuorum: "2" | ||
PULSAR_PREFIX_systemTopicEnabled: "true" | ||
PULSAR_PREFIX_topicLevelPoliciesEnabled: "true" | ||
# Enable the new delayed message | ||
delayedDeliveryTrackerFactoryClassName: "org.apache.pulsar.broker.delayed.BucketDelayedDeliveryTrackerFactory" | ||
# Enable transaction buffer segmented snapshot | ||
transactionBufferSegmentedSnapshotEnabled: "true" | ||
# Enable the new Load Balancer, please make sure your cluster is already on Pulsar 3.0 then to use. | ||
# Mix of new and previous Load Balancer in the same cluster will lead to unexpected problems. | ||
# loadManagerClassName: "org.apache.pulsar.broker.loadbalance.extensions.ExtensibleLoadManagerImpl" | ||
# loadBalancerLoadSheddingStrategy: "org.apache.pulsar.broker.loadbalance.extensions.scheduler.TransferShedder" | ||
### Broker service account | ||
## templates/broker-service-account.yaml | ||
# deprecated: use `serviceAccount` section to configure service account. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I think maybe we should support dynamic calculate of the segment size or bucket size by cluster resources in the future. :)
/cc @coderzc WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but we need to design a set of calculation formulas.