Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update the offload config #1091

Merged
merged 1 commit into from
Aug 25, 2023
Merged

fix: update the offload config #1091

merged 1 commit into from
Aug 25, 2023

Conversation

ericsyh
Copy link
Member

@ericsyh ericsyh commented Aug 25, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

  1. remove the managedLedgerOffloadDriver config in values.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ericsyh ericsyh requested review from sijie, addisonj and a team as code owners August 25, 2023 06:41
@ericsyh ericsyh added this to the sn-platform-1.11 milestone Aug 25, 2023
@ericsyh ericsyh requested a review from tuteng August 25, 2023 06:41
@github-actions github-actions bot added the doc-required This pr needs a document label Aug 25, 2023
@ericsyh ericsyh merged commit fc14b4b into master Aug 25, 2023
@ericsyh ericsyh deleted the offload branch August 25, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required This pr needs a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants