-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sn-platform(-slim)] Support readOnlyRootFilesystem #1136
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@ciiiii:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
doc-info-missing
This pr needs to mark a document option in description
and removed
doc-info-missing
This pr needs to mark a document option in description
labels
Dec 15, 2023
@ciiiii:Thanks for providing doc info! |
yaalsn
previously approved these changes
Dec 15, 2023
tuteng
previously approved these changes
Dec 15, 2023
yaalsn
approved these changes
Dec 21, 2023
tuteng
approved these changes
Dec 21, 2023
ericsyh
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Expose variable KUBECTL_BIN and OUTPUT * Define KUBECTL_BIN and OUTPUT to writable path * Toolset support readOnlyRootFilesystem * Detector support readOnlyRootFilesystem * Fix zk cluster indent * Add rootless example (cherry picked from commit 6cd50a0)
ericsyh
pushed a commit
that referenced
this pull request
Dec 21, 2023
* Expose variable KUBECTL_BIN and OUTPUT * Define KUBECTL_BIN and OUTPUT to writable path * Toolset support readOnlyRootFilesystem * Detector support readOnlyRootFilesystem * Fix zk cluster indent * Add rootless example (cherry picked from commit 6cd50a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support rootless env
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)