Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sn-platform(-slim)] Support readOnlyRootFilesystem #1136

Merged
merged 10 commits into from
Dec 21, 2023

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Dec 15, 2023

Motivation

Support rootless env

Modifications

  • toolset readOnlyRootFilesystem
  • jwt init job readOnlyRootFilesystem
  • pulsar detector readOnlyRootFilesystem

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from a team as code owners December 15, 2023 09:44
Copy link

@ciiiii:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Dec 15, 2023
Copy link

@ciiiii:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Dec 15, 2023
yaalsn
yaalsn previously approved these changes Dec 15, 2023
tuteng
tuteng previously approved these changes Dec 15, 2023
@ciiiii
Copy link
Member Author

ciiiii commented Dec 19, 2023

Added rootless example values, PTAL again @yaalsn @tuteng @ericsyh

@ciiiii ciiiii merged commit 6cd50a0 into master Dec 21, 2023
4 checks passed
@ciiiii ciiiii deleted the yscai/readOnlyRootFilesystem branch December 21, 2023 11:51
ericsyh pushed a commit that referenced this pull request Dec 21, 2023
* Expose variable KUBECTL_BIN and OUTPUT

* Define KUBECTL_BIN and OUTPUT to writable path

* Toolset support readOnlyRootFilesystem

* Detector support readOnlyRootFilesystem

* Fix zk cluster indent

* Add rootless example

(cherry picked from commit 6cd50a0)
ericsyh pushed a commit that referenced this pull request Dec 21, 2023
* Expose variable KUBECTL_BIN and OUTPUT

* Define KUBECTL_BIN and OUTPUT to writable path

* Toolset support readOnlyRootFilesystem

* Detector support readOnlyRootFilesystem

* Fix zk cluster indent

* Add rootless example

(cherry picked from commit 6cd50a0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants