Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prom config when istio enabled #1168

Merged
merged 2 commits into from
Jun 7, 2024
Merged

Fix prom config when istio enabled #1168

merged 2 commits into from
Jun 7, 2024

Conversation

ciiiii
Copy link
Member

@ciiiii ciiiii commented Jun 4, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

kubernetes-nodes and kubernetes-cadvisor scrape job will be disabled when istio enabled, we should remove the limitation

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@ciiiii ciiiii requested review from a team as code owners June 4, 2024 09:12
@ciiiii ciiiii requested a review from ericsyh June 4, 2024 09:12
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 4, 2024
Copy link
Contributor

@yuweisung yuweisung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look clear to me.

@ciiiii ciiiii requested a review from tuteng June 6, 2024 06:53
@ericsyh ericsyh merged commit 3371514 into master Jun 7, 2024
2 checks passed
@ericsyh ericsyh deleted the yscai/fix-prom-config branch June 7, 2024 06:50
ericsyh pushed a commit that referenced this pull request Jun 11, 2024
ericsyh pushed a commit that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants