Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed non auth token for console login when non auth enabled #1172

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Jun 12, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tuteng tuteng requested review from a team as code owners June 12, 2024 04:15
Copy link

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 12, 2024
@ericsyh ericsyh merged commit 8dab52f into master Jun 12, 2024
2 checks passed
@ericsyh ericsyh deleted the fixed/update-non-auth-token branch June 12, 2024 08:05
ericsyh added a commit that referenced this pull request Jun 12, 2024
ericsyh added a commit that referenced this pull request Jun 12, 2024
…#1173)

Revert "Fixed non auth token for console login when non auth enabled (#1172)"

This reverts commit 8dab52f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants