Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed base64 decode on Alpine based image #1176

Merged
merged 1 commit into from
Jun 19, 2024
Merged

Fixed base64 decode on Alpine based image #1176

merged 1 commit into from
Jun 19, 2024

Conversation

merlimat
Copy link
Contributor

Motivation

The base64 command on Alpine requires different arguments.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@merlimat merlimat requested review from a team as code owners June 19, 2024 05:05
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jun 19, 2024
@ericsyh ericsyh merged commit ae562ad into master Jun 19, 2024
2 checks passed
@ericsyh ericsyh deleted the merlimat-patch-1 branch June 19, 2024 05:30
ericsyh pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants