Remove unused log conf #1187
Merged
Remove unused log conf #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@labuladong:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
fantapsody
approved these changes
Oct 21, 2024
ericsyh
pushed a commit
that referenced
this pull request
Oct 22, 2024
rm unused log conf (cherry picked from commit 0d475e5)
ericsyh
pushed a commit
that referenced
this pull request
Oct 22, 2024
rm unused log conf (cherry picked from commit 0d475e5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a legacy issue to use hard code log4j2 config.
Now we are using
logConfigin CR.Fixes https://github.com/streamnative/eng-support-tickets/issues/1881