-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration examples for OIDC/security and metrics #1384
Conversation
b58d1ac
to
2f58374
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, Mike. I made a few minor suggestions on descriptions as I read through. Feel free to ignore any. I think it might be useful to have a sentence to describe what we're looking at in each example yaml and and how to go about using it.
metricsSources: | ||
# type=openshift-monitoring requires no other attributes, but truststore may be used if necessary | ||
- name: my-ocp-prometheus | ||
type: openshift-monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will this always be openshift-monitoring
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this example, yes. But, the type
value is an enumeration. It could be one of openshift-monitoring
, standalone
, or embedded
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would they require additional attributes? Just thinking of what would be needed in the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openshift-monitoring
and embedded
do not take any additional attributes. However, standalone
requires a url
and optionally takes authentication
and a trustStore
. The examples/console/console-standalone-prometheus.yaml
includes them as well.
Signed-off-by: Michael Edgar <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
Co-authored-by: PaulRMellor <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
9813bd9
to
d7a5b43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike.
Summaries look great
Few minor suggestions
metricsSources: | ||
# type=openshift-monitoring requires no other attributes, but truststore may be used if necessary | ||
- name: my-ocp-prometheus | ||
type: openshift-monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would they require additional attributes? Just thinking of what would be needed in the docs.
# Using claims is only supported when OIDC security is enabled. | ||
- claim: groups | ||
include: | ||
- team-a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. Makes sense for me.
Co-authored-by: PaulRMellor <[email protected]>
Signed-off-by: Michael Edgar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one more thought, Mike.
Mention placeholder in description.
Co-authored-by: PaulRMellor <[email protected]>
Quality Gate passedIssues Measures |
No description provided.