Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move schema link to message details drawer #1393

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hemahg
Copy link
Contributor

@hemahg hemahg commented Jan 21, 2025

  • Move the schema link to the message details drawer
    Screenshot 2025-01-21 at 10 54 27 PM

  • Improve how the schema is displayed in the new browser tab
    Screenshot 2025-01-21 at 10 54 37 PM

@hemahg hemahg requested a review from MikeEdgar January 22, 2025 03:18
@hemahg hemahg added enhancement New feature or request ui labels Jan 22, 2025
@hemahg hemahg added this to the 0.6.2 milestone Jan 22, 2025
ui/middleware.ts Outdated
Comment on lines 64 to 65
const isPublicPage =
(!oidcEnabled && publicPathnameRegex.test(requestPath)) || isSchemaPublic;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making schemas public won't work without API changes. When OIDC is enabled, the entire /api path will be protected so these requests will return a 401. Can the schemas still be under (authorized) somehow? Is it conflicting with some other path?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand the concern about the /api path being protected when OIDC is enabled. However, I am passing anonymous: true in the headers by using await getHeaders(true). This should allow the request to bypass authentication, similar to how Kafka logging is handled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah okay, I see the problem

Signed-off-by: hemahg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants