-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move schema link to message details drawer #1393
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: hemahg <[email protected]>
Signed-off-by: hemahg <[email protected]>
ui/middleware.ts
Outdated
const isPublicPage = | ||
(!oidcEnabled && publicPathnameRegex.test(requestPath)) || isSchemaPublic; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making schemas public won't work without API changes. When OIDC is enabled, the entire /api
path will be protected so these requests will return a 401. Can the schemas still be under (authorized)
somehow? Is it conflicting with some other path?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand the concern about the /api path being protected when OIDC is enabled. However, I am passing anonymous: true in the headers by using await getHeaders(true). This should allow the request to bypass authentication, similar to how Kafka logging is handled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah okay, I see the problem
Signed-off-by: hemahg <[email protected]>
Quality Gate passedIssues Measures |
Move the schema link to the message details drawer
Improve how the schema is displayed in the new browser tab