Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apicurio Registry direct dependency management, remove Nimbus JOSE mgmt #1398

Merged
merged 1 commit into from
Jan 23, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -72,18 +72,10 @@
<groupId>io.quarkus</groupId>
<artifactId>quarkus-hibernate-validator</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-kafka-client</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-kubernetes-client</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-apicurio-registry-avro</artifactId>
</dependency>
<dependency>
<groupId>io.quarkus</groupId>
<artifactId>quarkus-oidc</artifactId>
Expand All @@ -93,6 +85,11 @@
<artifactId>smallrye-common-annotation</artifactId>
</dependency>

<dependency>
<groupId>org.apache.kafka</groupId>
<artifactId>kafka-clients</artifactId>
</dependency>

<dependency>
<groupId>org.jboss.logging</groupId>
<artifactId>jboss-logging</artifactId>
Expand Down Expand Up @@ -120,7 +117,6 @@
<dependency>
<groupId>io.apicurio</groupId>
<artifactId>apicurio-registry-serdes-protobuf-serde</artifactId>
<version>${apicurio-registry.version}</version>
</dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
import java.util.List;
import java.util.Map;

import com.github.streamshub.console.kafka.systemtest.deployment.ApicurioResourceManager;
import com.github.streamshub.console.kafka.systemtest.deployment.KafkaResourceManager;
import com.github.streamshub.console.kafka.systemtest.deployment.KeycloakResourceManager;
import com.github.streamshub.console.kafka.systemtest.deployment.StrimziCrdResourceManager;
Expand Down Expand Up @@ -37,6 +38,7 @@ public String getConfigProfile() {
@Override
public List<TestResourceEntry> testResources() {
return List.of(
new TestResourceEntry(ApicurioResourceManager.class, Collections.emptyMap(), true),
new TestResourceEntry(StrimziCrdResourceManager.class, Collections.emptyMap(), true),
new TestResourceEntry(KeycloakResourceManager.class, Collections.emptyMap(), true),
new TestResourceEntry(KafkaResourceManager.class, Map.of("profile", PROFILE), true));
Expand All @@ -50,11 +52,7 @@ public Map<String, String> getConfigOverrides() {

schemaRegistries:
- name: test-registry
###
# This is the property used by Dev Services for Apicurio Registry
# https://quarkus.io/guides/apicurio-registry-dev-services
###
url: ${mp.messaging.connector.smallrye-kafka.apicurio.registry.url}
url: ${console.test.apicurio-url}

kafka:
clusters:
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
package com.github.streamshub.console.kafka.systemtest.deployment;

import java.io.BufferedReader;
import java.io.IOException;
import java.io.InputStream;
import java.io.InputStreamReader;
import java.io.UncheckedIOException;
import java.util.Map;

import org.slf4j.LoggerFactory;
import org.testcontainers.containers.GenericContainer;
import org.testcontainers.containers.output.Slf4jLogConsumer;
import org.testcontainers.containers.wait.strategy.Wait;

import io.quarkus.test.common.QuarkusTestResourceLifecycleManager;

public class ApicurioResourceManager implements QuarkusTestResourceLifecycleManager {

GenericContainer<?> apicurio;

@Override
@SuppressWarnings("resource")
public Map<String, String> start() {
int port = 8080;
String apicurioImage;

try (InputStream in = getClass().getResourceAsStream("/Dockerfile.apicurio");
BufferedReader reader = new BufferedReader(new InputStreamReader(in))) {
apicurioImage = reader.readLine().substring("FROM ".length());
} catch (IOException e) {
throw new UncheckedIOException(e);
}

apicurio = new GenericContainer<>(apicurioImage)
.withLogConsumer(new Slf4jLogConsumer(LoggerFactory.getLogger("systemtests.apicurio"), true))
.withExposedPorts(port)
.waitingFor(Wait.forListeningPort());

apicurio.start();

String urlTemplate = "http://localhost:%d/apis/registry/v2/";
var apicurioUrl = urlTemplate.formatted(apicurio.getMappedPort(port));
return Map.of("console.test.apicurio-url", apicurioUrl);
}

@Override
public void stop() {
apicurio.stop();
}
}
4 changes: 4 additions & 0 deletions api/src/test/resources/Dockerfile.apicurio
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
FROM quay.io/apicurio/apicurio-registry-mem:2.6.7.Final
# No operations, this is only a placeholder used to manage the image
# version via dependabot. The FROM statement is always expected to
# present on the first line of this file.
21 changes: 15 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -87,17 +87,26 @@
<artifactId>kafka-clients</artifactId>
<version>3.9.0</version>
</dependency>
<!-- Manage nimbus-jose-jwt for CVE-2023-52428 -->
<dependency>
<groupId>com.nimbusds</groupId>
<artifactId>nimbus-jose-jwt</artifactId>
<version>9.41.2</version>
</dependency>
<dependency>
<groupId>io.strimzi</groupId>
<artifactId>kafka-oauth-client</artifactId>
<version>${strimzi-oauth.version}</version>
</dependency>
<dependency>
<groupId>io.apicurio</groupId>
<artifactId>apicurio-registry-client</artifactId>
<version>${apicurio-registry.version}</version>
</dependency>
<dependency>
<groupId>io.apicurio</groupId>
<artifactId>apicurio-registry-serdes-avro-serde</artifactId>
<version>${apicurio-registry.version}</version>
</dependency>
<dependency>
<groupId>io.apicurio</groupId>
<artifactId>apicurio-registry-serdes-protobuf-serde</artifactId>
<version>${apicurio-registry.version}</version>
</dependency>
<dependency>
<groupId>io.strimzi</groupId>
<artifactId>kafka-oauth-common</artifactId>
Expand Down