[CI] Fix and unify image tags to lowercase, fix cut on localhost #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankalinic
changed the title
jankalinic
added
do not merge
MikeEdgar
requested changes
Jul 18, 2024
There was a problem hiding this comment.
Looks good. Thanks @jankalinic . A few comments and I think the release job may not need to change since it only uses numeric anyway.
Signed-off-by: jkalinic <[email protected]>
Signed-off-by: jkalinic <[email protected]>
Signed-off-by: jkalinic <[email protected]>
jankalinic
force-pushed
the
fix-snapshot-tags
branch
from
ef15f7a to
424ce03
Compare
|
MikeEdgar
added
ready for merge
MikeEdgar
removed
the
ready for merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some minor issues where images were being tagged with uppercase, while catalog was created with lower case image tag. This resulted in images missing in registry and back-off errors during operator deployment.