Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single cluster support, with dynamic authentication #941

Merged
merged 18 commits into from
Aug 9, 2024
Merged

Conversation

riccardo-forina
Copy link
Collaborator

@riccardo-forina riccardo-forina commented Jul 31, 2024

Changes

Homepage

Doesn't require authentication, shows the available clusters.

image

Login screen for clusters with SCRAM-SHA authN

image

Login screen for clusters with OAuth (token) authN

image

Login screen for unauthenticated clusters

image

Post-login homepage (cluster overview), and all other screens

Side-navigation shows only the cluster's links. The recently viewed topic is here now. The rest of the app isn't changed.
To log in to a different cluster, users will have to logout first; they'll land on the homepage.

image

@riccardo-forina riccardo-forina force-pushed the single-cluster branch 3 times, most recently from 0baef06 to e5cc69d Compare August 8, 2024 09:45
@riccardo-forina riccardo-forina marked this pull request as ready for review August 8, 2024 13:25
Copy link
Contributor

@hemahg hemahg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything looks great to me

@MikeEdgar
Copy link
Member

The brokers page doesn't work for me and I'm having a tough time debugging it. I pushed a commit with the middleware pattern fix.

@riccardo-forina
Copy link
Collaborator Author

Thank you. What error are you getting in the brokers page? I tested it without a Prometheus connection set up, and the page was showing ok with the warning that there was missing data. I didn't test it again against a working Prometheus

@MikeEdgar
Copy link
Member

The nodes table does not display at all, but the header and Prometheus warning do display. I am also not connected to a Prometheus instance. I've tried setting log statements where the API call to the Kafka cluster is made, but they aren't being shown on the console, even though the API server logs show requests are being made 😭

Generally, I also can improve things by deleting the .next directory and restarting, which makes me think the caching is again causing problems. Note, that did not help with the nodes page.

@riccardo-forina
Copy link
Collaborator Author

Yeah without Prometheus you will not see Anthony at all other than the warning and the table header. It's not great, but I'm not sure what else we can show there without Prometheus. But I'll check again tomorrow

@MikeEdgar MikeEdgar added the safe to test Mark the PR as safe to test label Aug 9, 2024
@MikeEdgar MikeEdgar removed the safe to test Mark the PR as safe to test label Aug 9, 2024
Copy link
Member

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified working with #916

Copy link

sonarqubecloud bot commented Aug 9, 2024

@MikeEdgar MikeEdgar merged commit ec472bd into main Aug 9, 2024
9 checks passed
@MikeEdgar MikeEdgar deleted the single-cluster branch August 9, 2024 15:16
@shirimordechay
Copy link

  • I don't see value in keeping the collapsable card option for the clusters login list. we can use a simple card
  • Does the Tech Preview badge appear in the upstream version as well?
  • Should the Prometheus warning only show once instead of repeatedly displaying the message?

@MikeEdgar
Copy link
Member

  • I don't see value in keeping the collapsable card option for the clusters login list. we can use a simple card

  • Does the Tech Preview badge appear in the upstream version as well?

  • Should the Prometheus warning only show once instead of repeatedly displaying the message?

@shirimordechay , the Tech Preview badge is present upstream. I need to defer to @riccardo-forina (when he returns) and @hemahg for the other two questions 😄

@hemahg
Copy link
Contributor

hemahg commented Aug 13, 2024

@shirimordechay, yes we can make use of a simple card. collapsable card is not needed in this case.
For the Prometheus warning, using the is a good approach to allow users to dismiss the alert when they see it. wdyt

@shirimordechay
Copy link

I think providing an error with a link to documentation on how to enable Prometheus would be helpful for users who are unsure how to proceed. I'm not sure what you meant by "allowing users to dismiss the alert when they see it." Is the alert dismissible?

@hemahg
Copy link
Contributor

hemahg commented Aug 14, 2024

Currently, the alert as implemented is not dismissible by default. My previous suggestion to include an would make the alert dismissible, allowing users to close it manually if they see it.
However, considering your suggestion, providing an error message with a link to documentation on how to enable Prometheus could indeed be very helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants