-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single cluster support, with dynamic authentication #941
Conversation
6e7a8ae
to
bec4f0f
Compare
0baef06
to
e5cc69d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks great to me
The brokers page doesn't work for me and I'm having a tough time debugging it. I pushed a commit with the middleware pattern fix. |
Thank you. What error are you getting in the brokers page? I tested it without a Prometheus connection set up, and the page was showing ok with the warning that there was missing data. I didn't test it again against a working Prometheus |
The nodes table does not display at all, but the header and Prometheus warning do display. I am also not connected to a Prometheus instance. I've tried setting log statements where the API call to the Kafka cluster is made, but they aren't being shown on the console, even though the API server logs show requests are being made 😭 Generally, I also can improve things by deleting the |
Yeah without Prometheus you will not see Anthony at all other than the warning and the table header. It's not great, but I'm not sure what else we can show there without Prometheus. But I'll check again tomorrow |
2ef6301
to
349f6a2
Compare
Signed-off-by: hemahg <[email protected]>
Signed-off-by: hemahg <[email protected]>
ae45b2b
to
1713ffc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified working with #916
Quality Gate passedIssues Measures |
|
@shirimordechay , the Tech Preview badge is present upstream. I need to defer to @riccardo-forina (when he returns) and @hemahg for the other two questions 😄 |
@shirimordechay, yes we can make use of a simple card. collapsable card is not needed in this case. |
I think providing an error with a link to documentation on how to enable Prometheus would be helpful for users who are unsure how to proceed. I'm not sure what you meant by "allowing users to dismiss the alert when they see it." Is the alert dismissible? |
Currently, the alert as implemented is not dismissible by default. My previous suggestion to include an would make the alert dismissible, allowing users to close it manually if they see it. |
Changes
Homepage
Doesn't require authentication, shows the available clusters.
Login screen for clusters with SCRAM-SHA authN
Login screen for clusters with OAuth (token) authN
Login screen for unauthenticated clusters
Post-login homepage (cluster overview), and all other screens
Side-navigation shows only the cluster's links. The recently viewed topic is here now. The rest of the app isn't changed.
To log in to a different cluster, users will have to logout first; they'll land on the homepage.