Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the patternfly group in /ui with 7 updates #994

Merged
merged 4 commits into from
Sep 3, 2024
+308 −365
Merged

Bump the patternfly group in /ui with 7 updates #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
abcd735
Bump the patternfly group in /ui with 7 updates
dependabot[bot] Aug 28, 2024
1484bba
fix: add "root" div to UI layout
MikeEdgar Aug 28, 2024
1c97bbb
storybook action updates
MikeEdgar Aug 28, 2024
7151416
Add preview-body with div required by patternfly
MikeEdgar Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions .github/workflows/storybook.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,26 +17,24 @@ jobs:
with:
fetch-depth: 0

- name: Install Dependencies
run: npm install
working-directory: ./ui

- name: Build Storybook
run: npm run build-storybook
working-directory: ./ui
run: |
npm ci
npx playwright install
npm run build-storybook

- name: Publish to Chromatic
id: chromatic
uses: chromaui/action@v11
with:
token: ${{ secrets.GITHUB_TOKEN }}
projectToken: chpt_0314d7b0d66ad0c
projectToken: ${{ secrets.CHROMATIC_PROJECT_TOKEN }}
storybookBuildDir: "storybook-static"
workingDir: "./ui"
exitOnceUploaded: true

- name: Test the deployed Storybook
- name: Test Storybook
working-directory: ./ui
run: |
npx playwright install
npm run test-storybook -- --no-index-json --url ${{ steps.chromatic.outputs.storybookUrl }}
working-directory: ./ui
1 change: 1 addition & 0 deletions ui/.storybook/preview-body.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<div id="root"></div>
4 changes: 3 additions & 1 deletion ui/app/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,9 @@ type Props = {
export default function RootLayout({ children }: Props) {
return (
<html lang="en">
<body>{children}</body>
<body>
<div id="root">{children}</div>
</body>
</html>
);
}
Loading