Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helpfile updates #106

Merged
merged 25 commits into from
Apr 19, 2021
Merged

Helpfile updates #106

merged 25 commits into from
Apr 19, 2021

Conversation

isabelgk
Copy link
Contributor

This PR covers issues:

#67
#70
#71
#79
#85
#86
#88
#89
#90
#91
#97
#98
#99
#100
#101
#102
#103
#104

isabelgk added 25 commits April 13, 2021 11:55
This uncovered an issue with MFFB where MFFB doesn't initialize the filter
and so signal doesn't pass through until a bank has been edited. This
should be logged as a separate issue.
@isabelgk
Copy link
Contributor Author

Two wonky things with Samplr are occurring right now, one of which was already present, which I'm working on:

  1. (Was present before my changes) Setting the loop points anywhere but the beginning and end doesn't work as expected — the sample doesn't just play that looped section
  2. (A result of my changes) Dropping in the Samplr clipping doesn't show up in presentation mode

@stretta stretta merged commit d0136a8 into stretta:master Apr 19, 2021
@stretta
Copy link
Owner

stretta commented Apr 19, 2021

samplr issues are noted in this ticket #71

isabelgk added a commit to isabelgk/BEAP that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants