Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove "Refactor" project #2686

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jklawreszuk
Copy link
Collaborator

PR Details

PR removes unnecessary project containing only redundant wrapper around NotImplementedException class.
Description states that it " can be easily tracked by finding usages", but the same goal can be easily achieved by using a global search in any IDE ... (CTRL + SHIFT + F)

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Kryptos-FR
Copy link
Member

I think the original idea was to be able to find these specific not implemented features, as opposed to getting every other not implemented cases.

However, since it's an old TODO, I think it's fair to remove them. I didn't check by maybe the error message can be put into a constant (it looks like it's the same in most places) so that we can easily find again those same places.

@Jklawreszuk
Copy link
Collaborator Author

Thanks for explanation, it might be worthwhile to make a compilation of features to be implemented as a github issue 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants