Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tolu/link/wallet list UI #9691

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Tolu/link/wallet list UI #9691

wants to merge 8 commits into from

Conversation

toluo-stripe
Copy link
Contributor

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Before After
before screenshot after screenshot

Changelog

@toluo-stripe
Restore consumer payment detail fields
4e8fb56
@toluo-stripe
List link payment methods
0af8967
@toluo-stripe
Update parser
4bc5e81
@toluo-stripe
Link Payment Details UI
e0ed111
@toluo-stripe
Update PaymentDetailsListItemScreenShotTest.kt
98a4d44 
Add screenshots

Minor fixes

clean up

fix test theme

Fix screenshots

Remove strings

remove unused payment details

remove alpha

Delete screenshots

Update strings.xml

Update screenshots

Fix screenshots
@toluo-stripe
Wallet list screen
62b5dc6
@toluo-stripe
Wallet Payment Methods UI
fd8c4e5
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024 •
edited
Loading

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼──────────┬──────────┬───────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff      
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
      dex │   3.9 MiB │   3.9 MiB │ +9.4 KiB │  8.5 MiB │  8.5 MiB │ +22.5 KiB 
     arsc │   2.3 MiB │   2.3 MiB │ +3.1 KiB │  2.3 MiB │  2.3 MiB │  +3.1 KiB 
 manifest │     5 KiB │     5 KiB │      0 B │ 24.9 KiB │ 24.9 KiB │       0 B 
      res │ 904.1 KiB │ 906.3 KiB │ +2.3 KiB │  1.4 MiB │  1.4 MiB │  +4.5 KiB 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │    +14 B │  1.6 MiB │  1.6 MiB │     +14 B 
    other │   1.4 MiB │   1.4 MiB │   +231 B │  1.6 MiB │  1.6 MiB │    +496 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
    total │  12.6 MiB │  12.7 MiB │  +15 KiB │ 21.5 MiB │ 21.5 MiB │ +30.7 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 40361 │ 40406 │ +45 (+81 -36)     
   types │ 13920 │ 13945 │ +25 (+57 -32)     
 classes │ 11605 │ 11630 │ +25 (+37 -12)     
 methods │ 59302 │ 59388 │ +86 (+3940 -3854) 
  fields │ 39539 │ 39617 │ +78 (+2720 -2642) 

 ARSC    │ old  │ new  │ diff       
─────────┼──────┼──────┼────────────
 configs │  243 │  243 │  0         
 entries │ 6197 │ 6204 │ +7 (+7 -0)
APK 
     compressed      │     uncompressed      │                                
──────────┬──────────┼───────────┬───────────┤                                
 size     │ diff     │ size      │ diff      │ path                           
──────────┼──────────┼───────────┼───────────┼────────────────────────────────
  3.9 MiB │ +9.4 KiB │   8.5 MiB │ +22.5 KiB │ ∆ classes.dex                  
  2.3 MiB │ +3.1 KiB │   2.3 MiB │  +3.1 KiB │ ∆ resources.arsc               
  1.1 KiB │ +1.1 KiB │   2.5 KiB │  +2.5 KiB │ + res/mU1.xml                  
    633 B │   +633 B │   1.2 KiB │  +1.2 KiB │ + res/FG1.xml                  
    557 B │   +557 B │     880 B │    +880 B │ + res/vB.xml                   
 50.1 KiB │   +117 B │ 118.3 KiB │    +248 B │ ∆ META-INF/MANIFEST.MF         
 53.4 KiB │   +112 B │ 118.3 KiB │    +248 B │ ∆ META-INF/CERT.SF             
    662 B │    +31 B │   1.2 KiB │     -68 B │ ∆ res/FG.xml                   
  7.8 KiB │    +24 B │   7.7 KiB │     +24 B │ ∆ assets/dexopt/baseline.prof  
    999 B │    -10 B │     867 B │     -10 B │ ∆ assets/dexopt/baseline.profm 
  1.2 KiB │     +2 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA            
──────────┼──────────┼───────────┼───────────┼────────────────────────────────
  6.3 MiB │  +15 KiB │  11.1 MiB │ +30.7 KiB │ (total)
DEX 
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   40361 │ 40406 │ +45 (+81 -36) 
  
  + +multiple_funding_sources@
  + , selectedItem=
  + <a href="https://stripe.com/legal/ach-payments/authorization">
  + ChevronIcon
  + LB6/a;
  + LB6/b;
  + LB6/c;
  + LB6/d;
  + LB6/e;
  + LB6/f;
  + LB6/g;
  + LB6/h;
  + LB6/i;
  + LB6/j;
  + LB6/k;
  + LB6/l;
  + LB6/m;
  + LB6/n;
  + LB6/o;
  + LB6/p;
  + LB6/q;
  + LB6/r;
  + LE5/x;
  + LLFJL
  + LM5/w;
  + LN6/S;
  + LQ9/e;
  + LS/F3;
  + LS/G3;
  + LS/H3;
  + La/a;
  + Lg8/n;
  + Lg8/o;
  + Lg9/f;
  + LinkColors(componentBackground=
  + Ln6/F;
  + Lo6/o;
  + Lr6/c;
  + Ls6/n;
  + Lv6/w;
  + Lv6/x;
  + Lx7/k;
  + Ly7/q;
  + PaymentMethod
  + VJJJJJJJJJJLJJJJL
  + VLFJLI
  + VLLFJI
  + VZLZLLI
  + WalletUiState(paymentDetailsList=
  + WalletViewModel Fatal error: 
  + [LM8/B0;
  + [LM8/O;
  + [LM8/P0;
  + [LM8/T0;
  + [LM8/T;
  + [LM8/W0;
  + [LS/B3;
  + [LS/l2;
  + [LS7/Z;
  + [LS7/v0;
  + [LX8/E;
  + [LX8/x;
  + [Lg8/j;
  + [Lg8/n;
  + [Lg8/o;
  + [Lh6/p;
  + [Ln6/A;
  + [Ls0/v;
  + [Lv6/j;
  + [Lv6/x;
  + consumers/payment_details/list
  + linkAccount
  + navigate
  + onExpandedChanged
  + onItemSelected(Lcom/stripe/android/model/ConsumerPaymentDetails_PaymentDetails;)V
  + onMenuButtonClick
  + paymentDetailsList
  + payment_detail_
  + selectedPaymentMethod
  + setExpanded(Z)V
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"08dba8f","r8-mode":"full","version":"8.7.14"}
  
  - LD5/X;
  - LD7/n;
  - LI5/c;
  - LJ5/F;
  - LJ5/G;
  - LJ5/H;
  - LL5/t;
  - LM8/F1;
  - Lb3/i;
  - Lh6/A;
  - Lh6/B;
  - LinkColors(componentBorder=
  - Lw5/e;
  - VJJJJJJJJLJJJJL
  - WalletScreen
  - [LM8/C0;
  - [LM8/Q0;
  - [LM8/Q;
  - [LM8/U0;
  - [LM8/U;
  - [LM8/X0;
  - [LS/k2;
  - [LS/y3;
  - [LS7/Y;
  - [LS7/t0;
  - [LX8/D;
  - [LX8/w;
  - [Lg8/h;
  - [Lg8/i;
  - [Lg8/l;
  - [Lh6/r;
  - [Ln6/z;
  - [Ls0/u;
  - [Lv6/h;
  - [Lv6/v;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"9488a95","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   13920 │ 13945 │ +25 (+57 -32) 
  
  + LB6/a;
  + LB6/b;
  + LB6/c;
  + LB6/d;
  + LB6/e;
  + LB6/f;
  + LB6/g;
  + LB6/h;
  + LB6/i;
  + LB6/j;
  + LB6/k;
  + LB6/l;
  + LB6/m;
  + LB6/n;
  + LB6/o;
  + LB6/p;
  + LB6/q;
  + LB6/r;
  + LE5/x;
  + LM5/w;
  + LN6/S;
  + LQ9/e;
  + LS/F3;
  + LS/G3;
  + LS/H3;
  + La/a;
  + Lg8/n;
  + Lg8/o;
  + Lg9/f;
  + Ln6/F;
  + Lo6/o;
  + Lr6/c;
  + Ls6/n;
  + Lv6/w;
  + Lv6/x;
  + Lx7/k;
  + Ly7/q;
  + [LM8/B0;
  + [LM8/O;
  + [LM8/P0;
  + [LM8/T0;
  + [LM8/T;
  + [LM8/W0;
  + [LS/B3;
  + [LS/l2;
  + [LS7/Z;
  + [LS7/v0;
  + [LX8/E;
  + [LX8/x;
  + [Lg8/j;
  + [Lg8/n;
  + [Lg8/o;
  + [Lh6/p;
  + [Ln6/A;
  + [Ls0/v;
  + [Lv6/j;
  + [Lv6/x;
  
  - LD5/X;
  - LD7/n;
  - LI5/c;
  - LJ5/F;
  - LJ5/G;
  - LJ5/H;
  - LL5/t;
  - LM8/F1;
  - Lb3/i;
  - Lh6/A;
  - Lh6/B;
  - Lw5/e;
  - [LM8/C0;
  - [LM8/Q0;
  - [LM8/Q;
  - [LM8/U0;
  - [LM8/U;
  - [LM8/X0;
  - [LS/k2;
  - [LS/y3;
  - [LS7/Y;
  - [LS7/t0;
  - [LX8/D;
  - [LX8/w;
  - [Lg8/h;
  - [Lg8/i;
  - [Lg8/l;
  - [Lh6/r;
  - [Ln6/z;
  - [Ls0/u;
  - [Lv6/h;
  - [Lv6/v;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   59302 │ 59388 │ +86 (+3940 -3854) 
  
  + A2.e <init>(q, m, int)
  + A5.c <init>(a, g, E, int)
  + A6.l <init>(a, b, e, c)
  + A6.s <init>(b, m, b, d, a, c)
  + A6.s i(k) → c
  + B.L <init>(h, a, p, c, h0, int)
  + B.m0 x(i, String, int) → m1
  + B6.a <clinit>()
  + B6.a f(Object, Object) → Object
  + B6.b <clinit>()
  + B6.c <clinit>()
  + B6.c d(Object, Object, Object) → Object
  + B6.d <clinit>()
  + B6.e <init>(w, boolean, boolean, a, a, int)
  + B6.e <init>(p, F0, boolean, boolean, c, int)
  + B6.e <init>(p, boolean, boolean, String, a, int)
  + B6.e <init>(boolean, boolean, w, x, p, int)
  + B6.e f(Object, Object) → Object
  + B6.f <init>(boolean, a, int, int)
  + B6.f f(Object, Object) → Object
  + B6.g <init>(g1, n0, g1, b, a, int)
  + B6.g <init>(j, c, a, a, p, int)
  + B6.g <init>(A, a, a, c, c, int)
  + B6.g <init>(Object, Object, Object, Object, Object, int, int)
  + B6.g <init>(Object, Object, a, a, c, int, int)
  + B6.g <init>(String, x, a, Integer, Integer, int)
  + B6.g f(Object, Object) → Object
  + B6.h <init>(p, c, c, int, int)
  + B6.h f(Object, Object) → Object
  + B6.i <init>(int, c)
  + B6.i a() →
...✂
ARSC 
ENTRIES:

   old  │ new  │ diff       
  ──────┼──────┼────────────
   6197 │ 6204 │ +7 (+7 -0) 
  + drawable/stripe_link_add_green
  + drawable/stripe_link_bank
  + drawable/stripe_link_chevron
  + string/stripe_wallet_bank
  + string/stripe_wallet_expand_accessibility
  + string/stripe_wallet_last4_prefix
  + string/stripe_wallet_passthrough_description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@toluo-stripe