Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore testCoreEventsGet generated test #1805

Merged
merged 2 commits into from
Jan 17, 2025
Merged

Conversation

jar-stripe
Copy link
Contributor

Why?

We have generated example tests that test service endpoints. \Stripe\V2\Event is an abstract base class for V2 events, and the return type of EventService.retrieve. Because the Event class was abstract, we could not include it in convertToStripeObject and therefore could not include this generated test.

What?

  • made v2 event class concrete, and changed convertToStripeObject to use it if we cannot find the identified event subclass
  • add comment on event class explaining its role
  • added generated test testCoreEventsGet

…e it if we cannot find the identified event subclass

added generated test testCoreEventsGet
@jar-stripe jar-stripe enabled auto-merge (squash) January 14, 2025 00:59
@jar-stripe jar-stripe merged commit e81186f into master Jan 17, 2025
22 checks passed
@jar-stripe jar-stripe deleted the jar/fix-php-event-test branch January 17, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants