Explicitly format timestamp in SignatureVerificationError message #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
anniel-stripe
requested changes
Aug 21, 2023
There was a problem hiding this comment.
Thanks for opening this PR! This looks great, would you mind fixing the linting error and updating your branch? After that we can hit merge :)
magni-
force-pushed
the
pp/to_s-rails-deprecation
branch
from
cc6f3bd
to
ab00c5e
Compare
|
@anniel-stripe Thanks for the review, fixed the rubocop offenses and rebased! |
When interpolating a Time object in a String, Ruby calls `to_s` under the hood. For Rails applications defining a `default` string format, this triggers deprecation warnings as of v7.0.7: rails/rails#48555 This change fixes that by explicitly formatting the timestamp (using the same `YYYY-MM-DD HH:mm:ss` format currently implicitly used).
magni-
force-pushed
the
pp/to_s-rails-deprecation
branch
from
ab00c5e
to
41c536a
Compare
anniel-stripe
approved these changes
Aug 22, 2023
|
Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When interpolating a Time object in a String, Ruby calls
to_sunder the hood.For Rails applications defining a
defaultstring format, this triggers deprecation warnings as of v7.0.7: rails/rails#48555This change fixes that by explicitly formatting the timestamp (using the same
YYYY-MM-DD HH:mm:ssformat currently implicitly used).