Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tokens): add support for sSTRK token and pools #197

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

feat(tokens): add support for sSTRK token and pools #197

wants to merge 5 commits into from

Conversation

0xdevcollins
Copy link

PR Fixes:

  • 1 Added Dex pools for sSTRK listed on Ekubo and Nostra.
  • 2 Integrated DeFi Spring rewards for sSTRK into Ekubo and Nostra codebase.

Resolves #190

Vercel website link

Checklist before requesting a review

  • I have performed a self-review of my code
  • I assure there is no similar/duplicate pull request regarding same issue
  • My PR passes all checks (build, lint, formatting, etc)

@0xdevcollins
Copy link
Author

I get this error when I build
image

@akiraonstarknet
Copy link
Contributor

@0xdevcollins there error could be bcz of improper env variables.
@EjembiEmmanuel can help

@akiraonstarknet
Copy link
Contributor

@0xdevcollins
I dont think STRK Staking pool (sSTRK) by Nimbora is added. Even that needs to be added. Check endur protocol for reference.

Second, sSTRK pool on Vesu and Nostra (Lending/borrow) is not added.

@akiraonstarknet akiraonstarknet self-requested a review December 23, 2024 09:56
EjembiEmmanuel
EjembiEmmanuel requested changes Dec 28, 2024
View reviewed changes
src/store/ekobu.store.ts Outdated
@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be SSTRK not sSTRK

src/store/ekobu.store.ts Outdated
@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
'sSTRK/ETH',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

src/store/ekobu.store.ts Outdated
@@ -175,6 +175,9 @@ export class Ekubo extends IDapp<EkuboBaseAprDoc> {
'USDT',
'ETH',
'STRK',
'sSTRK/USDC',
'sSTRK/ETH',
'sSTRK',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

EjembiEmmanuel
EjembiEmmanuel requested changes Dec 28, 2024
View reviewed changes
src/constants.ts Outdated
@@ -77,6 +85,19 @@ const CONSTANTS = {
};

export const TOKENS: TokenInfo[] = [
{
token: standariseAddress(
'0x0260c02fd6942c788b8905d2c1b98b5a98fffd2ec0dfb013aa4b148781e269b6',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The token contract address should be 0x0356f304b154d29d2a8fe22f1cb9107a9b564a733cf6b4cc47fd121ac1af90c9

@EjembiEmmanuel
Copy link
Collaborator

Please deploy your app on Vercel and provide the link in the description

@EjembiEmmanuel
Copy link
Collaborator

@0xdevcollins any progress?

@0xdevcollins
Copy link
Author

@0xdevcollins any progress?

I update the Pr today

@EjembiEmmanuel
Copy link
Collaborator

Alright

@EjembiEmmanuel
Copy link
Collaborator

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@EjembiEmmanuel
Copy link
Collaborator

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins any progress with this?

@0xdevcollins
Copy link
Author

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@EjembiEmmanuel
Copy link
Collaborator

EjembiEmmanuel commented Jan 25, 2025 •
edited
Loading

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins it appears you deployed from your dev branch instead of your feature branch because I can't see your changes. Please redeploy from your feature branch.

@EjembiEmmanuel
Copy link
Collaborator

https://starkfarm-client-dun.vercel.app

@0xdevcollins please deploy your app on Vercel and provide the link in the description

@0xdevcollins it appears you deployed from your dev branch instead of your feature branch because I can't see your changes. Please redeploy from your feature branch.

@0xdevcollins any update?

akiraonstarknet
akiraonstarknet requested changes Feb 2, 2025
View reviewed changes
src/constants.ts
@@ -9,6 +9,7 @@ const LOGOS = {
WBTC: '/zklend/icons/tokens/wbtc.svg?w=20',
ETH: '/zklend/icons/tokens/eth.svg?w=20',
STRK: '/zklend/icons/tokens/strk.svg?w=20',
SSTRK: '/zklend/icons/tokens/strk.svg?w=20',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Invalid sSTRK logo url. Also, its sSTRK, not SSTRK (The first s is small)

src/constants.ts
token: standariseAddress(
'0x0356f304b154d29d2a8fe22f1cb9107a9b564a733cf6b4cc47fd121ac1af90c9',
),
name: 'SSTRK',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its sSTRK, not SSTRK

src/store/nostradex.store.ts
@@ -18,7 +18,14 @@ export class NostraDex extends Jediswap {
if (!myData) return [];
const pools: PoolInfo[] = [];

const supportedPools = ['ETH-USDC', 'STRK-ETH', 'STRK-USDC', 'USDC-USDT'];
const supportedPools = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change has no impact on logic. sSTRK pool on nostra is shown even without this change.

.codegpt/head
@@ -0,0 +1 @@
095b1ce0-c1b8-4464-9692-ad6ed63effed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary file. Please add to .codegpt to gitignore and refresh gitignore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EjembiEmmanuel EjembiEmmanuel EjembiEmmanuel requested changes

@akiraonstarknet akiraonstarknet akiraonstarknet requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: Add sSTRK DEX pools
3 participants
@0xdevcollins @akiraonstarknet @EjembiEmmanuel