Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEMVER-MAJOR] Remove current-context API #2564

Merged
merged 2 commits into from
Aug 10, 2016

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jul 29, 2016

Change all current-context APIs to throw a helpful error.

This is a follow-up for strongloop/loopback-context#1

Based on our discussions, I think we should remove getCurrentContext from LoopBack 3.0. In order to simplify upgrade path and allow community to take over maintenance of CLS-based current context, I want to follow the same process we did with loopback-boot and that is to extract the functionality into a standalone module that can be versioned independently.

See also #2559 which deprecates current-context API in 2.x.

@raymondfeng @ritch please review
cc @strongloop/loopback-dev FYI

@raymondfeng
Copy link
Member

LGTM

@bajtos
Copy link
Member Author

bajtos commented Aug 1, 2016

@slnode test please

@bajtos
Copy link
Member Author

bajtos commented Aug 9, 2016

I am waiting for https://github.com/strongloop/loopback-context/pull/3/files before landing this PR.

@bajtos bajtos force-pushed the feature/remove-current-context branch from 48204c0 to 7ea5b91 Compare August 10, 2016 11:40
@bajtos bajtos assigned bajtos and unassigned ritch and raymondfeng Aug 10, 2016
bajtos added 2 commits August 10, 2016 13:43
Change all current-context APIs to throw a helpful error.
@bajtos bajtos force-pushed the feature/remove-current-context branch from 7ea5b91 to 59a82a9 Compare August 10, 2016 11:44
@bajtos bajtos merged commit f13e584 into master Aug 10, 2016
@bajtos bajtos deleted the feature/remove-current-context branch August 10, 2016 12:14
@bajtos bajtos removed the #review label Aug 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants