Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: automatic releasing #68

Merged
merged 1 commit into from
Feb 7, 2023
Merged

Chore: automatic releasing #68

merged 1 commit into from
Feb 7, 2023

Conversation

niek-mereu
Copy link
Collaborator

@niek-mereu niek-mereu commented Feb 7, 2023 •
edited
Loading

📝 Changelog

  • extract the tag from github afer pushing the tag and insert it into setup.py
  • make releasing independent of merging into master, but dependent on pushing a new tag
  • remove version number from package.json

🔗 Links

✅ Checklist

  • Lint and tests pass locally with my changes
  • I've added necessary documentation

@niek-mereu niek-mereu self-assigned this Feb 7, 2023
@niek-mereu niek-mereu marked this pull request as draft February 7, 2023 12:30
@niek-mereu niek-mereu force-pushed the chore/automatic-releasing branch from 2c25c00 to 8f128e7 Compare February 7, 2023 12:32
@niek-mereu niek-mereu changed the title Chore/automatic releasing Chore: automatic releasing Feb 7, 2023
@niek-mereu niek-mereu marked this pull request as ready for review February 7, 2023 12:37
@niek-mereu niek-mereu requested review from jardabezdek and joeythedataguy and removed request for jardabezdek February 7, 2023 12:37
jardabezdek
jardabezdek approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@jardabezdek jardabezdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

@niek-mereu niek-mereu merged commit d5ae411 into master Feb 7, 2023
@niek-mereu niek-mereu deleted the chore/automatic-releasing branch February 7, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jardabezdek jardabezdek jardabezdek approved these changes

@joeythedataguy joeythedataguy Awaiting requested review from joeythedataguy

Assignees

@niek-mereu niek-mereu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niek-mereu @jardabezdek