Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cleanup & tweaks, vol.2 #9

Merged
merged 5 commits into from
Mar 8, 2024
Merged

Conversation

robertrossmann
Copy link
Member

This is the final round of "random" tweaks and improvements before I move on to rewriting the README.

  • refactored the Observer struct into an interface and provided the DefaultObserver as an implementation of it
  • moved Task struct and related functionality into a separate file
  • implemented Manager.Close() that is a helper function which calls both .Wait() and .Cancel() in parallel. Useful to completely shut this thing down all at once.
  • minor tweaks to the CI definition, plus added a lint step to the pipeline. 🎨

@robertrossmann robertrossmann added the enhancement New feature or request label Mar 7, 2024
@robertrossmann robertrossmann requested a review from a team March 7, 2024 11:41
@robertrossmann robertrossmann self-assigned this Mar 7, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 97.14286% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.37%. Comparing base (691ccee) to head (cdbbef8).

Files Patch % Lines
background.go 95.65% 1 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feat/looping-tasks       #9      +/-   ##
======================================================
+ Coverage               98.13%   98.37%   +0.24%     
======================================================
  Files                       3        3              
  Lines                     107      123      +16     
======================================================
+ Hits                      105      121      +16     
  Misses                      2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from feat/looping-tasks to master March 8, 2024 12:39
@robertrossmann robertrossmann merged commit 5830d8b into master Mar 8, 2024
3 checks passed
@robertrossmann robertrossmann deleted the feat/cleanup-vol-2 branch March 8, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants