Prevent keyboard from playing if modifier key is pressed #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a check to the keydown callback to return out if a modifier key is pressed before an actual key. Expand the key-simulator test helper to enable keyboardEvent.metaKey testing
|
@ahoym Thanks for this! Seems to fail the build though. :person_with_pouting_face: |
initKeyboardEvent doesn't play nicely in Firefox, and didn't register its metaKey argument. initKeyEvent works as intended in Firefox, and doesn't exist in Chrome. Checking for existence of the latter instead of the former enables both test suites to pass.
|
Gah, this was a classic case of cross browser struggles!
|
|
Amazing, thank you again! ⚡ |
stuartmemo
added a commit
that referenced
this pull request
Sep 23, 2015
Prevent keyboard from playing if modifier key is pressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #9
This PR:
Something I noticed though is that even though this works for something like Cmd + L, if someone did L + Cmd, it will still hold the L at keydown until pressed again.