Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from deku to cookie-factory and nom #10

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Jun 6, 2022

deku is a bit overkill for a small parser like this. We don't have to perform any bit level manipulation nor is the format itself complex enough to warrant using a parser generator

The switch also gets rid of proc macros and the alloc requirement (making this crate entirely no_std compatible)


I'm not entirely sure whether the deserialise and serialise functions are idiomatic to cookie-factory/nom (as in that they can be used in generator/parser chains)

@aumetra aumetra force-pushed the nom-cookie-factory branch from 682861e to 0c1f09e Compare June 6, 2022 20:30
@aumetra aumetra marked this pull request as draft June 6, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant