flatten ast, remove arena #75
suaviloquenceci.yml
on: pull_request
run cargo tests
55s
verify formatting and lints
41s
Annotations
3 errors and 10 warnings
|
verify formatting and lints:
src/frontend/ast.rs#L47
length comparison to zero
|
|
verify formatting and lints:
src/frontend/ast.rs#L54
length comparison to zero
|
|
verify formatting and lints
Process completed with exit code 101.
|
|
verify formatting and lints:
filter-types/src/value.rs#L121
casting `f64` to `i64` may truncate the value
|
|
verify formatting and lints:
filter-types/src/value.rs#L130
casting `i64` to `f64` causes a loss of precision (`i64` is 64 bits wide, but `f64`'s mantissa is only 52 bits wide)
|
|
verify formatting and lints:
src/frontend/ast.rs#L46
docs for function which may panic missing `# Panics` section
|
|
verify formatting and lints:
src/frontend/ast.rs#L53
docs for function which may panic missing `# Panics` section
|
|
verify formatting and lints:
src/frontend/ast.rs#L217
it is more concise to loop over references to containers instead of using explicit iteration methods
|
|
verify formatting and lints:
src/frontend/parser.rs#L52
this method could have a `#[must_use]` attribute
|
|
verify formatting and lints:
src/frontend/parser.rs#L72
docs for function returning `Result` missing `# Errors` section
|
|
verify formatting and lints:
src/frontend/parser.rs#L78
docs for function returning `Result` missing `# Errors` section
|
|
verify formatting and lints:
src/frontend/parser.rs#L314
consider adding a `;` to the last statement for consistent formatting
|
|
verify formatting and lints:
src/frontend/parser.rs#L389
this function's return value is unnecessarily wrapped by `Result`
|