[Go] Fix slice date type highlighting #3843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sublimehq#3842 This commit refactors `pop-type-single` context: 1. don't pop it off stack when matching `[` so arbitrary numbers of bracket pairs (slices) can be contained. 2. removes `pop-after-brackets` after `]` is matched as all its content is also part of `pop-type-single`. 3. simplify the context by removing some unneeded lookaheads. `pop-type-identifier` is included directly at last position as it also includes the `pop-before-nonblank`.
jrappen
approved these changes
Oct 31, 2023
keith-hall
approved these changes
Oct 31, 2023
FichteFoll
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3842
This commit refactors
pop-type-singlecontext:don't pop it off stack when matching
[so arbitrary numbers of bracket pairs (slices) can be contained.removes
pop-after-bracketsafter]is matched as all its content is also part ofpop-type-single.simplify the context by removing some unneeded lookaheads.
pop-type-identifieris included directly at last position as it also includes thepop-before-nonblank.