[JavaScript] Clean up imports #3851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit... 1. adds a named context `import-export-from-name` 2. adds a bailout in case `from` source literal is missing, so following statements don't break highlighting.
This commit... 1. adds named context for optional object-literals in export/import statements. 2. adds a test case to verify bailout of incomplete statements.
This commit... 1. adds named context for export-default expressions. 2. adds a test case to verify bailout of incomplete statements.
michaelblyons
previously approved these changes
Oct 1, 2023
Add some named contexts and bailouts
deathaxe
approved these changes
Oct 1, 2023
michaelblyons
approved these changes
Oct 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import/export-braceandimport/export-item. They're not identical in the grammar, but they're close enough and they don't conflict.import type from 'somewhere';in TypeScript. (import typeandexport typecannot share an implementation because they have different corner cases.)withkeyword for import assertions. This is a breaking change in the import assertions proposal. Currently, TypeScript supports both, butassertis deprecated; this PR supports both.