Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Fix block comment punctuation #3856

Merged

Conversation

deathaxe
Copy link
Collaborator

This commit adds scoping for leading asterisks in (normal) block comments so ST's word_wrap command can add them to each wrapped line, if present in the first one.

Notes:

This change aligns JavaScript with Java and C/C++.

Related with #3855

This commit adds scoping for leading asterisks in (normal) block comments
so ST's word_wrap command can add them to each wrapped line, if present in
the first one.

Notes:

This change aligns JavaScript with Java and C/C++.

Related with sublimehq#3855
@Thom1729 Thom1729 merged commit dad085f into sublimehq:master Oct 23, 2023
2 checks passed
@deathaxe deathaxe deleted the pr/javascript/block-comment-punctuation branch October 23, 2023 19:40
deathaxe added a commit to deathaxe/sublime-packages that referenced this pull request Nov 17, 2023
This commit ...

1. fixes missing closing `punctuation.definition` scopes
2. renames a `.js` final scope to `.json`
3. adjusts leading asterisk scoping according to sublimehq#3855 and sublimehq#3856.
4. refactors comment related contexts to use only named contexts.
deathaxe added a commit that referenced this pull request Nov 17, 2023
This commit ...

1. fixes missing closing `punctuation.definition` scopes
2. renames a `.js` final scope to `.json`
3. adjusts leading asterisk scoping according to #3855 and #3856.
4. refactors comment related contexts to use only named contexts.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants