Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Batch File] Tweak comment collapsing #3865

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

mataha
Copy link
Contributor

@mataha mataha commented Nov 5, 2023

This commit introduces two changes:

  • @rem (silenced rem) and ::: (safe equivalent of ::) have been added
  • rem and its silent equivalent @rem now use TM_COMMENT_CASE_INSENSITIVE introduced in Sublime Text 4153, which allows collapsing comments casefold

This commit introduces two changes:

 - `@rem` (silenced `rem`) and `:::` (safe equivalent of `::`) have been added
 - `rem` and its silent equivalent `@rem` now use `TM_COMMENT_CASE_INSENSITIVE`
   introduced in Sublime Text 4153, which allows collapsing comments casefold
@jrappen
Copy link
Contributor

jrappen commented Nov 6, 2023

From a quick glance at the syntax, these don't seem to have been added there nor to the tests.

@FichteFoll
Copy link
Collaborator

FichteFoll commented Nov 6, 2023

these don't seem to have been added there nor to the tests

Because they're not needed.

Now, one could argue that all colons in ::: should get the punctuation.definition.comment scope (currently only the first 2), but that's orthogonal to this PR which is mostly concerned about the toggle_comment command.

2023-11-06_16-59-41

mataha added a commit to mataha/sublime-packages that referenced this pull request Nov 6, 2023
@mataha
Copy link
Contributor Author

mataha commented Nov 6, 2023

these don't seem to have been added there nor to the tests

Because they're not needed.

Exactly.

Now, one could argue that all colons in ::: should get the punctuation.definition.comment scope (currently only the first 2), but that's orthogonal to this PR which is mostly concerned about the toggle_comment command.

I've addressed this in #3866.

@deathaxe deathaxe merged commit 52dcf9a into sublimehq:master Nov 6, 2023
2 checks passed
@mataha mataha deleted the feat/batch/comment-collapsing branch November 6, 2023 18:17
FichteFoll pushed a commit that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants