-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CSS] Add support for at-scope rule #3869
base: master
Are you sure you want to change the base?
Conversation
Resolves sublimehq#3867 This commit implements support for @scope rules. see: https://developer.mozilla.org/en-US/docs/Web/CSS/@scope
Because when I also use it in the latest stable build I get the same behavior |
CSS has significanty changed since ST4152. Hence, you'd need to replace the whole CSS.sublime-syntax file. It may however have effects on 3rd-party syntaxes such as Less as those may need some tweaks to follow these changes. |
Which is what I did I extracted Packages/CSS using PackageResourcwViewer then copied your version and replaced the other |
As all CI tests (against ST4143 and ST4165) are passing it must be an issue on your end. |
That may be true, but tests can always send false positives. I have been using Sublime Text ever since Sublime Text 2 I'm not new. & furthermore it was when I changed your code thats it started working like it should |
As test results are equal with what I see, when symlinking this branch into a vanilla ST4152 portable setup's Packages folder, I tend to trust them. The only "inaccuracy" this branch has, is allowing arbritary ammounts of |
Is what I meant in that comment |
Note: @scope is supported by all major browsers and no longer marked experimental. |
Any update on this? |
This PR is waiting a 2nd approval by a maintainer to enable merging. |
Resolves #3867
This commit implements support for @scope rules.
see: https://developer.mozilla.org/en-US/docs/Web/CSS/@scope
Notes: At the time of writing it is an experimental feature not supported by all major browsers.