[Python] Add SQL syntax highlighting in f-strings #3888
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrappen
approved these changes
Dec 15, 2023
|
Appreciate the notes in the commit message. |
jfcherng
approved these changes
Dec 16, 2023
|
I'd like to see an actual use case of using SQL with an f-string before adding this, considering that it significantly increases the cache size along with #3046 (by 33%!) for what seems like rather little gain. I have some ideas for building an sql statement from a string where a prepared statement (with proper value insertion) would not suffice, but I still doubt whether an f-string is the best or even a proper solution in those cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3885
This PR proposes to add support for SQL syntax highlghting within f-strings.
I have no strong opinion about adding this.
The change was easy, so proposing it for thosw who want it.
Note: With #3046 Python's syntax cache grows from about 3MB to 4MB with this PR merged.