[TypeScript] Non-null assertion is not an accessor #3893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrappen
approved these changes
Dec 15, 2023
michaelblyons
approved these changes
Dec 15, 2023
deathaxe
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3890.
I figured out what I was thinking. I added the
!postfix operator todot_accessorbecause it kept things like function call detection working without further alteration. This PR tweaks a few contexts to make everything work without wrongly marking the!in!.as an accessor.I also changed a few contexts to use literal
?.instead of thedot_accessorvariable when just a dot wouldn't be valid anyway. And I moved the!postfix operator toleft-expression-end. I have to imagine that having it inexpression-endinstead might have caused some subtle bugs, but I'm not sufficiently motivated to track those down (if indeed they ever existed).