[CSS] Relaxed Nesting Support #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements relaxed syntax for nested style rules according to https://www.w3.org/TR/css-nesting-1/#nested-style-rule. In general it means, nested selectors of nested style rules no longer need to start with `&` operator to denote html tags. The implementation adopts `properties-or-selectors` context from Less syntax to achieve reliable distinction between declarations and selectors without loosing support for interpolation.
This commit renames `style-block` contexts to `stylesheet-block` in order to avoid confusion with official syntax specs, because a `style-block` is actually what is represented by `property-lists` contexts in this syntax definition. A stylesheet block's content is however equal to top-level content, which does not support declarations (property-value pairs).
|
It appears SCSS and Less are becoming obsolete. |
michaelblyons
changed the title
|
Note that lazy nesting is supported by all major browsers. |
keith-hall
approved these changes
Feb 9, 2024
jrappen
approved these changes
Feb 14, 2024
|
Thanks, appreciate the work on this. |
jfcherng
approved these changes
Feb 17, 2024
|
Thanks for reviewing. |
deathaxe
added a commit
to SublimeText/Less
that referenced
this pull request
Feb 24, 2024
As of ST4149 `&` is part of selector_start in CSS and doesn't need to be explicitly added by Less. Variable `selector_begin` is maintained only for backward compatibility with some unreleased revisions of core CSS. Variable `property_or_selector_begin` as adjusted to match CSS (as of sublimehq/Packages#3898) and is maintained for backward compatibility with ST builds which do not ship that PR.
|
How is this fix distributed - does it come bundled in a mainstream Sublime build, or will this be published independently to the Sublime package registry sooner than that? |
Yes, eventually.
No, but you can get it early with the README instructions, or I think jfcherng has a script to get the latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3897
This commit implements relaxed syntax for nested style rules according to https://www.w3.org/TR/css-nesting-1/#nested-style-rule.
In general it means, nested selectors of nested style rules no longer need to start with
&operator to denote html tags.The implementation adopts
properties-or-selectorscontext from Less syntax to achieve reliable distinction between declarations and selectors without loosing support for interpolation.