Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Markdown] Fix premature block quote termination #3900

Merged

Conversation

deathaxe
Copy link
Collaborator

Fixes #3892 (comment)

Follow up commit for #3892.

@deathaxe deathaxe marked this pull request as ready for review December 30, 2023 16:48
michaelblyons
michaelblyons previously approved these changes Dec 30, 2023
This commit removes block-quote punctuation contexts from being pushed on stack,
which do not have any effect in conjunction with Github Alerts.

They are required support multiple > > > markers in front of content, which is
not supported by Github Alerts.

Due to consuming caption text pushing those contexts does actually nothing, but
causing some extra round-trips.
@deathaxe
Copy link
Collaborator Author

Found some obsolete contexts being pushed on stack and removed them. Those don't do anything in conjuction with alerts.

@FichteFoll FichteFoll merged commit 9ba6b93 into sublimehq:master Jan 1, 2024
2 checks passed
@deathaxe deathaxe deleted the pr/markdown/fix-blockquote-termination branch January 1, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants