[Rust] Use keyword.declaration scope
#3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following the example of Java, we're replacing the `storage.type` scope with `keyword.declaration` without keeping the `storage.type` for compatibility. Also, like in Java, the `use` keyword gets a `keyword.declaration.import` scope to signal that it is introducing names into the current namespace. `type` aliases have slightly been refactored to properly match `where` clauses. (I did a bit of work twice here because I forgot to `git pull` before and included the remainder …)
FichteFoll
force-pushed
the
pr/rust/keyword-declaration
branch
from
8346f21 to
7f7708c
Compare
keith-hall
previously approved these changes
Jan 29, 2024
keith-hall
approved these changes
Jan 31, 2024
deathaxe
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the example of Java, we're replacing the
storage.typescopewith
keyword.declarationwithout keeping thestorage.typeforcompatibility. Also, like in Java, the
usekeyword gets akeyword.declaration.importscope to signal that it is introducingnames into the current namespace.
typealiases have slightly been refactored to properly matchwhereclauses. (I did a bit of work twice here because I forgot to
git pullbefore and included the remainder …)
Closes #3640.