[Python] Improve type alias definitions #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathaxe
force-pushed
the
pr/python/fix-type-alias-definitions
branch
from
b1c1ccc to
582c45b
Compare
Fixes sublimehq#3902 This commit ensures to highlight `type` more context sensitively. It may have the following meanings: 1. built-in `type()` function 2. type alias declaration keyword: `type Alias` 3. ordinary variable used in many data classes The built-in function (1.) most likely appears in r-value expressions, such as `my_type = type(var)` At beginning of statements this commit prefers scoping `type` as keyword (2.) or variable (3.) as this is the most likely use case. The implementation ensures to start `meta` scope of alias declarations at bol as class or function declarations do.
deathaxe
force-pushed
the
pr/python/fix-type-alias-definitions
branch
from
582c45b to
df98fff
Compare
keith-hall
approved these changes
Feb 3, 2024
jfcherng
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3902
This commit ensures to highlight
typemore context sensitively.It may have the following meanings:
type()functiontype AliasThe built-in function (1.) most likely appears in r-value expressions, such as
my_type = type(var)At beginning of statements this commit prefers scoping
typeas keyword (2.) or variable (3.) as this is the most likely use case.The implementation ensures to start
metascope of alias declarations at bol as class or function declarations do.