[YAML] Improve Performance #3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathaxe
force-pushed
the
pr/yaml/optimize
branch
from
baf9003 to
34009aa
Compare
This commit improves parsing performance by about 4-6%.
This commit improves parsing performance by about 16%. It reorganizes imports in `block-node-11` and `block-node-12` contexts in order to avoid `flow-scalar-plain-out-1x` and `flow-scalar-plain-in-1x` being included at the same time.
deathaxe
force-pushed
the
pr/yaml/optimize
branch
from
34009aa to
5620b3d
Compare
|
@keith-hall and @FichteFoll, this doesn't change anything you're extending, does it? Otherwise looks good to me. |
|
I've checked against
|
keith-hall
approved these changes
Feb 18, 2024
michaelblyons
approved these changes
Feb 18, 2024
FichteFoll
reviewed
Feb 19, 2024
Comment on lines
+97
to
+98
| \s+ \# | ||
| | \s* (?: $ | {{c_flow_indicator}} | : (?:\s|$|{{c_flow_indicator}}) ) |
There was a problem hiding this comment.
Was the effect on performance here caused by not grouping or by using a capturing group? Because I find the new grouping much harder to follow (though that could probably be solved by just splitting it over multiple lines).
There was a problem hiding this comment.
The duplicate \s* had most impact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes some changes to improve parsing performance by about 18-20%
Syntax cache size drops from 58kB to 41kB (-30%).