[CSS] Add :global() and :local() pseudo-classes #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `:global(selector)` and `:local(selector)` pseudo-class support. The former is used by CSS Modules, Less and Astro framework. The ladder is used by CSS Modules only, but is added for completeness. It is no default CSS feature, but appears to be specific enough to not cause any conflicts. Adding it to core CSS would avoid the need to extend CSS for Astro, just for this single reason.
FichteFoll
previously approved these changes
Mar 15, 2024
deathaxe
requested review from
FichteFoll,
michaelblyons,
jfcherng and
keith-hall
|
Another request for supporting This request technically also hits CSS as also being supported/used by vue.js Are there certain concerns against adding it here? |
michaelblyons
approved these changes
Jul 11, 2024
keith-hall
approved these changes
Jul 11, 2024
jfcherng
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
:global(selector)and:local(selector)pseudo-class support. The former is used by CSS Modules, Less and Astro framework. The ladder is used by CSS Modules only, but is added for completeness.It is no default CSS feature, but appears to be specific enough to not cause any conflicts.
Adding it to core CSS would avoid the need to extend CSS for Astro, just for this single reason.
Vue.js also uses
:global(see: https://vuejs.org/api/sfc-css-features.html#global-selectors).