Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[YAML] Add CITATION.cff file extension #3947

Merged
merged 2 commits into from
Mar 15, 2024
Merged

Conversation

jwortmann
Copy link
Contributor

https://citation-file-format.github.io/

Also see https://github.com/citation-file-format/citation-file-format/blob/main/schema-guide.md which states that the file must be named exactly CITATION.cff and that it is YAML.

jfcherng
jfcherng previously approved these changes Mar 14, 2024
@jfcherng
Copy link
Collaborator

jfcherng commented Mar 14, 2024

It's spec says CCF is in yaml format and the only reasonable usage seems to be CITATION.cff files.
https://citation-file-format.github.io/assets/pdf/cff-specifications-1.0.0.pdf

deathaxe
deathaxe previously approved these changes Mar 14, 2024
@deathaxe
Copy link
Collaborator

Would it make sense to add it to hidden_file_extensions as it points to a whole file, which is unlikely to be used as normal file extension and thus should be hidden from "Save as" dialog?

@jwortmann
Copy link
Contributor Author

Yes, I think that would be better. Currently it shows up as *.CITATION.cff if the "Save as" dialog, which could be misleading. I'll change it, unless there are any objections.

@jwortmann jwortmann dismissed stale reviews from deathaxe and jfcherng via b599cb8 March 14, 2024 18:59
@deathaxe deathaxe merged commit 6730d5e into sublimehq:master Mar 15, 2024
2 checks passed
@jwortmann jwortmann deleted the yaml-cff branch March 15, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants