-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[D] Make in
a word operator
#3964
Conversation
I wonder, would this stacking of I remember previous discussions leading to no solutions, and iirc Also see #3694 (comment)
|
Agree shouldn't be stacked after I searched the current code base. |
I'll change it to just use |
That will make this PR to more likely be merged. |
Primarily expected issues with regards to possible over-use of stacked scopes is the limit of at most 64 stacked scopes per token. Each additional scope may increase risk to break syntax highlighting in deeply nested statements. Now that syntax based folding really requires each block to provide its own meta scope to make sure each bracket is scoped uniquely, chances may even grow further - theoretically. (D doesn't follow this guideline at all, though) Using only If at all - the initial (stacked) solution would probably be the only accepteble one without breaking backward compatibility and by ignoring chapter one's outlined issue. But someone should then apply that pattern to ALL syntaxes in this repo! I however have a feeling this would require to also scope symbolic operators accordingly for consistency reasons, because it is odd to use 2 scopes for word-like operators but only 1 for symbolic ones. Tbh, I wouldn't merge it until a conclusion for #3694 is found. |
Changes:
in
as a word operator so that it can be highlighted as-such.