[JavaScript] Fix ST freezing #4003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes sublimehq/sublime_text#6416 Regressed by sublimehq#3836 This commit refactors for loop conditions to prevent ST's syntax engine to run into an infinite loop, if multiple nested for loops appear within branches, such as arrow functions. The issue seems to be triggered by ```yml for-condition-contents: - match: '' branch_point: for-in-of branch: - for-in-of - for-oldstyle pop: 1 ``` in conjunction with newlines. Note: It somewhat reorganizes expressions contexts a little bit.
|
I was able to confirm that this patch fixes the syntax highlighting errors for me. Thanks! |
keith-hall
approved these changes
Jun 29, 2024
jfcherng
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sublimehq/sublime_text#6416
Regressed by #3836
This commit refactors for loop conditions to prevent ST's syntax engine to run into an infinite loop, if multiple nested for loops appear within branches, such as arrow functions.
The issue seems to be triggered by
in conjunction with newlines.
Note: It somewhat reorganizes expressions contexts a little bit.