[Batch File] Refactor labels and label-like comments #4005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit starts implementing tokenization according to descriptions of https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts/4095133#4095133 for lables, which are also used as sort of line comments. It also highlights the odd parts, which includes not all valid looking labels being able to targeted in GOTO and CALL statements due to different tokenization rules being applied by dosbatch interpreter.
All sorts of words are terminated by common word boundaries (metachars), including path strings. It's obscure but `mkdir d1=d2` actually creates directories `d1` and `d2`.
This commit scopes `,` `;` and `=` punctuation.separator, if not otherwise addressed by more specific patterns to indicate their primary meaning.
This commit refactors some variable values to avoid nested charsets in patterns. Note: This commit does not change behavior.
mataha
reviewed
Jul 20, 2024
|
Any example of what's not working as expected would be helpful. Labels are treated special in some manners. Maybe I missed something. |
@echo off
for %%# in (1 2 3) do (call :label%%~#)
exit /b
@:label1 is a valid label unless in label context
$,=,= ,==, =,;;:,;=label2 see above, also 2>nul to suppress errors
* : label3 see above, also 2>nul to suppress errors
(echo(%0)
goto :EOF |
|
Well, I don't see any value in supporting all sorts of obscure expressions and doubt it is even possible. You'll find such edge cases in all syntaxes, but they are far away from "to be expected to be used". |
FichteFoll
approved these changes
Aug 25, 2024
michaelblyons
approved these changes
Aug 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies tokenization rules from https://stackoverflow.com/questions/4094699/how-does-the-windows-command-interpreter-cmd-exe-parse-scripts/4095133#4095133 to labels and common command arguments.
As a result invalid labels are scoped "ignored" even without dedicated comment contexts and less special-casing patterns. They are however kept to maintain
comment.linescopes for now.Delimiter characters such as
=are ignored, which fixes scoping of somewhat uncommon but valid labels like:=== label ===.Delimiter chars are scoped
punctuation.separatorif not having any other special meaning (e.g.:=keyword.operator.assignment) depending on context.Accuracy of various tokens - including some odds of batch - is increased to match highlighting better to interpreter's behavior.