Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mixed] Use detailed scope for true/false/null #4009

Merged
merged 21 commits into from
Jul 13, 2024
Merged

[Mixed] Use detailed scope for true/false/null #4009

merged 21 commits into from
Jul 13, 2024

Conversation

jfcherng
Copy link
Collaborator

@jfcherng jfcherng commented Jul 13, 2024 •
edited
Loading

This is good for those who want to use different colors for true/false.

This PR changes scopes of booleans in most languages.

Splits scope XXX.boolean.LANG into

  • XXX.boolean.true.LANG
  • XXX.boolean.false.LANG

Some also introduce new detailed scope for null/nil.

@jfcherng jfcherng marked this pull request as draft July 13, 2024 06:23
@jfcherng jfcherng changed the title [Python] Use detailed scope for True/False [Many] Use detailed scope for True/False Jul 13, 2024
@jfcherng jfcherng changed the title [Many] Use detailed scope for True/False [Mixed] Use detailed scope for True/False Jul 13, 2024
jfcherng added 9 commits July 13, 2024 14:54
@jfcherng
[Lua] Use detailed scope for true/false
9224f35 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[Go] Use detailed scope for true/false/nil
b690e46 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[R] Use detailed scope for true/false/null
4e3e4aa 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[OCaml] Use detailed scope for true/false
e573f96 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[Lisp] Use detailed scope for true/false
6c3090f 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[Java/JSP] Use detailed scope for true/false
65279cd 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[Groovy] Use detailed scope for true/false/null
32d0c65 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[Erlang] Use detailed scope for true/false
0218650 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng
[C/C++] Use detailed scope for true/false/NULL
126b14e 
Signed-off-by: Jack Cherng <[email protected]>
@jfcherng jfcherng marked this pull request as ready for review July 13, 2024 07:26
@jfcherng
Copy link
Collaborator Author

I think this has been done.

@jfcherng jfcherng changed the title [Mixed] Use detailed scope for True/False [Mixed] Use detailed scope for true/false/null Jul 13, 2024
deathaxe
deathaxe approved these changes Jul 13, 2024
View reviewed changes
Copy link
Collaborator

@deathaxe deathaxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems complete after the first glance. Even if not, we can always add remainers.

Thanks.

@deathaxe deathaxe merged commit 4a51942 into sublimehq:master Jul 13, 2024
4 checks passed
@jfcherng jfcherng deleted the sep-bool-scope branch July 13, 2024 09:08
FichteFoll added a commit to SublimeText/PackageDev that referenced this pull request Jul 13, 2024
@FichteFoll
Scope Data: Add boolean sub-scopes
9ee3b9d 
See also sublimehq/Packages#4009.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deathaxe deathaxe deathaxe approved these changes

@keith-hall keith-hall keith-hall approved these changes

@FichteFoll FichteFoll Awaiting requested review from FichteFoll

@michaelblyons michaelblyons Awaiting requested review from michaelblyons

@Thom1729 Thom1729 Awaiting requested review from Thom1729

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfcherng @keith-hall @deathaxe