[CSS] Fix issues with template interpolation #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit...
1. changes context include order to give `property-lists` less priority over
`{{ interpol }}` interpolation tags, so they are scoped as part of selectors
or property names.
2. in case strategy 1 is not enough, provide variables to override block
punctuation, without duplicating contexts.
Note: This commit does not change behavior of CSS itself, just helps inherited
CSS variants used in templates like Blade, Go, Jinja, Twig, ...
keith-hall
previously approved these changes
Oct 10, 2024
Co-authored-by: Keith Hall <[email protected]>
Co-authored-by: Keith Hall <[email protected]>
Co-authored-by: Keith Hall <[email protected]>
keith-hall
approved these changes
Oct 11, 2024
michaelblyons
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
changes context include order to give
property-listsless priority over{{ interpol }}interpolation tags, so they are scoped as part of selectors or property names.in case strategy 1 is not enough, provide variables to override block punctuation, without duplicating contexts.