[PHP] Optimize embedded CSS/JS syntax definitions #4060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes sure to pop CSS/JS contexts off stack, if quotation mark is matched by customizing relevant CSS/JS contexts only. By not injecting required lookahead into each context via `prototype`, compiled syntax cache size is reduced by round about 200kB as more contexts share same patterns. Modified syntax definitions are designed for being included into inline event and style attributes of HTML tags. Note: This commit does not change behavior, just saves some RAM.
keith-hall
approved these changes
Oct 20, 2024
jfcherng
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes sure to pop CSS/JS contexts off stack, if quotation mark is matched by customizing relevant CSS/JS contexts only.
By not injecting required lookahead into each context via
prototype, compiled syntax cache size is reduced by round about 200kB as more contexts share same patterns.Modified syntax definitions are designed for being included into inline event and style attributes of HTML tags.
Note: This commit does not change behavior, just saves some RAM.