[JavaScript] Add SQL embedding

[jtojnar]

• My commit messages start with the package name in square brackets, e.g. [XML] .
• I have included new or enhanced syntax tests to cover the changes.

This is useful for server-side JS.

Especially using one of the following libraries:
https://github.com/felixfbecker/node-sql-template-strings
https://github.com/blakeembrey/sql-template-tag
https://github.com/XeCycle/pg-template-tag

Using version: 1 for the Embedding syntaxes since they need to match the inherited SQL.sublime-syntax.

It does not currently handle interpolation inside SQL strings.

---

The SQL template is detected but the SQL syntax highlighting is not performed (source.sql.embedded.js is the deepest scope anything within the template string gets).

Edit: If I change extends: Packages/SQL/SQL.sublime-syntax to CSS.sublime-syntax in SQL (JS template).sublime-syntax, it highlights as CSS correctly.

Edit2 It was caused by a differing version.

[michaelblyons]

Does the SQL bump to version 2 then require a bunch of other "host" syntaxes to bump, too?

[jtojnar]

It requires the bump of the Embeddings syntaxes. For example, SQL (for Ruby).sublime-syntax needs to be version: 2, or the SQL example in syntax_test_ruby.rb will not be highlighted.

Curiously, Ruby.sublime-syntax itself does not seem to need to be bumped.

[michaelblyons]

It turns out my local set-up includes #3046, which also bumps to version 2. Sounds good to me.

[deathaxe]

Only inherited syntaxes need to be of same version. It is no problem to include or embed a v2 into a v1 or vice versa.

Bumping SQL to v2 and adding support for SQL in tagged template strings however are 2 distinct steps.

The more interesting question is what effect #3046 will have in combination with this one as JS is embedded, extended and used in nearly all template syntaxes. I wonder when we hit context sanity limits again. :D

[deathaxe]

With regards to #4035, any purley embedded syntax should be named <name> (for TS template).sublime-syntax.

Syntaxes in Embedding are currently not correctly named by accident.

[jtojnar]

Bumping SQL to v2 and adding support for SQL in tagged template strings however are 2 distinct steps.

Should I move the first commit out into a separate PR?

With regards to #4035, any purley embedded syntax should be named <name> (for TS template).sublime-syntax.

Fixed.

[deathaxe]

Should I move the first commit out into a separate PR?

I'd say yes. Bumping SQL version is a seperate PR. Actually I don't see any reason for it, at the moment. It would be part of merging #3046.

[jtojnar]

I'd say yes. Bumping SQL version is a seperate PR. Actually I don't see any reason for it, at the moment. It would be part of merging #3046.

Well, it is a prerequisite for this, since the embedding syntaxes inherit from the SQL one. So unless we want to wait with this PR for #3046 – but it has already been open for years – I have moved the SQL change to #4097.