-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Regexp backref identifiers #4110
[Python] Regexp backref identifiers #4110
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python always used to try to even correctly highlight py2. Do we need to bother users with deprecated highlighting, really?
I can yank the deprecated highlighting and tests, but there's a real change that is still necessary. I discovered it trying to name the groups in a capture as specific keys for |
I am fine with required fixes, if current patterns don't match all valid names. It's just the attempt to do linting by scoping no longer supported nonascii "deprecated". pyright and co. will already highlight them depending on set python version. They should however be highlighted normally by syntax as they are valid in older (even ST's default python versions) - even though actually rather unlikely to appear in real world projects, which is just another reason for not needing that extra complexity. |
Following example from LaTeXTools would be fixed by this PR. |
Centralizes named capture group identifiers in a variable. Adds support for capital letters one place they were missing. Adds support for
\g<...>
backref style.Relevant documentation in v3.12
Previously included (but now removed) deprecation scopes for non-ASCII capture group identifiers.