-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppleScript] sregex compatibility #4156
base: master
Are you sure you want to change the base?
Conversation
Whitespace, comments, and regex rearrangement
Thanks, Wikipedia!
Thanks for working on this. I still have some left-overs from rainy days from autumn with what I started with while going through this package. Should I send you a zip via Discord? |
Okay, now I'm doing more work on it. |
Not a full rebuild from spec and there are definitely some broken pieces, but it's lots better. Has some good building contexts if someone wants to push forward with Apple's crazy blocks. |
I noticed a few things:
|
@@ -0,0 +1,635 @@ | |||
# SYNTAX TEST "AppleScript.sublime-syntax" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# SYNTAX TEST "Packages/AppleScript/AppleScript.sublime-syntax"
Most of those were inherited. I guess I could check them against the spec, but I did see a line in the spec saying that almost everything is case insensitive.
Most of this is inherited, too. The only part I remember with a space is in the raw Unicode part, which isn't fully spec-conforming yet anyway.
I guess I could, but
Good thought. Will change. |
See #481
There's lots more that could be done to improve this package, but I've killed the lookbehinds and added a couple of subscopes. Also, there's a test file for the first time.