Replace Quick Fix label in hover popup with lightbulb icon (#2567)

sublimelsp · Dec 9, 2024 · 8f505fe · 8f505fe
1 parent 5cff692
commit 8f505fe
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 3 deletions.
diff --git a/icons/lightbulb_colored.png b/icons/lightbulb_colored.png
diff --git a/plugin/documents.py b/plugin/documents.py
@@ -526,7 +526,7 @@ def on_hover(self, point: int, hover_zone: int) -> None:
     def _on_hover_gutter_async(self, point: int) -> None:
         content = ''
         if self._lightbulb_line == self.view.rowcol(point)[0]:
-            content += code_actions_content(self._code_actions_for_selection)
+            content += code_actions_content(self._code_actions_for_selection, lightbulb=False)
         if userprefs().show_diagnostics_severity_level:
             diagnostics_with_config: list[tuple[ClientConfig, Diagnostic]] = []
             diagnostics_by_session_buffer: list[tuple[SessionBufferProtocol, list[Diagnostic]]] = []

diff --git a/plugin/hover.py b/plugin/hover.py
@@ -83,7 +83,7 @@ def link(self, point: int, view: sublime.View) -> str:
 ]
 
 
-def code_actions_content(actions_by_config: list[CodeActionsByConfigName]) -> str:
+def code_actions_content(actions_by_config: list[CodeActionsByConfigName], lightbulb: bool = True) -> str:
     formatted = []
     for config_name, actions in actions_by_config:
         action_count = len(actions)
@@ -95,8 +95,10 @@ def code_actions_content(actions_by_config: list[CodeActionsByConfigName]) -> st
             text = actions[0].get('title', 'code action')
         href = "{}:{}".format('code-actions', config_name)
         link = make_link(href, text)
+        lightbulb_html = '<span class="lightbulb"><img src="res://Packages/LSP/icons/lightbulb_colored.png"></span>' \
+            if lightbulb else ''
         formatted.append(
-            f'<div class="actions">Quick Fix: {link} <span class="color-muted">{config_name}</span></div>')
+            f'<div class="actions">{lightbulb_html}{link} <span class="color-muted">{config_name}</span></div>')
     return "".join(formatted)
 
 

diff --git a/popups.css b/popups.css
@@ -68,6 +68,13 @@
     color: var(--foreground);
     padding: 0.5rem;
 }
+.actions .lightbulb {
+    padding-right: 0.3rem;
+}
+.actions .lightbulb img {
+    width: 0.9em;
+    height: 0.9em;
+}
 .actions a.icon {
     text-decoration: none;
 }